Update Genome Nexus annotation module args#249
Draft
johnoooh wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task.ext.argsin the Genome Nexus annotation pipeline module commandtask.ext.prefixfor the annotated MAF output nameghcr.io/msk-access/genomenexus_annotation-pipeline:1.0.5versions.ymlrendering and add/update the nf-test stub snapshotfile('dummy.maf', checkIfExists: false)because the stub block does not read the input MAF; the normal test still exercises a real MAF through the existing test-data fixtureContainer note
This PR intentionally keeps the old container while the rebuilt Genome Nexus container is reviewed and built. Once the new container from mskcc-omics-workflows/containers#60 is available, this module can be switched to the updated
ghcr.io/mskcc-omics-workflows/genomenexus_annotation-pipeline:1.0.7image.Output inspection
I ran the updated module locally with the existing
1.0.5container and a local copy of the Genome Nexus fixture MAF because the configured raw GitHub test-data URL cannot address the slash branch currently used by the fixture.The generated command includes the configured args:
java -Xms768m -Xmx3g \ -jar /genome-nexus-annotation-pipeline/annotationPipeline/target/annotationPipeline.jar \ --filename input.maf \ --output-filename tiny-annotated.maf \ --isoform-override mskcc --replace-symbol-entrez --post-interval-size 1The output looked structurally correct:
tiny-annotated.mafcontains#genome_nexus_version: 2.1.3and#isoform: mskccsplice_donor_variant,Splice_Site, dbSNP, HGVSc, transcript, and RefSeq fields populatedAnnotation_Status=FAILED, matching the tool log summary of 2 failed annotationsOne caveat: the Genome Nexus jar logs an initial failed default batch attempt before the parameterized job completes successfully. The final parameterized job completed and Nextflow exited successfully. The current expected annotated fixture fetched from
test-datasetsappears stale or unannotated because it matches the input and differs from the real generated output.Validation
PATH=/Users/orgeraj/miniconda3/bin:$PATH NXF_DISABLE_CHECK_LATEST=true nf-test test modules/msk/genomenexus/annotationpipeline/tests/main.nf.test --tag stub --ciPATH=/Users/orgeraj/miniconda3/bin:$PATH NXF_DISABLE_CHECK_LATEST=true nf-test test --profile=docker --ci --shard 1/5 --filter process,workflow modules/msk/genomenexus/annotationpipeline/tests/main.nf.test --verboseghcr.io/msk-access/genomenexus_annotation-pipeline:1.0.5