Skip to content

Update Genome Nexus annotation module args#249

Draft
johnoooh wants to merge 2 commits into
developfrom
feature/genomenexus-annotationpipeline-args
Draft

Update Genome Nexus annotation module args#249
johnoooh wants to merge 2 commits into
developfrom
feature/genomenexus-annotationpipeline-args

Conversation

@johnoooh

@johnoooh johnoooh commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add support for task.ext.args in the Genome Nexus annotation pipeline module command
  • Use task.ext.prefix for the annotated MAF output name
  • Keep the existing container pinned to ghcr.io/msk-access/genomenexus_annotation-pipeline:1.0.5
  • Fix the stub versions.yml rendering and add/update the nf-test stub snapshot
  • Change the stub test input to file('dummy.maf', checkIfExists: false) because the stub block does not read the input MAF; the normal test still exercises a real MAF through the existing test-data fixture

Container note

This PR intentionally keeps the old container while the rebuilt Genome Nexus container is reviewed and built. Once the new container from mskcc-omics-workflows/containers#60 is available, this module can be switched to the updated ghcr.io/mskcc-omics-workflows/genomenexus_annotation-pipeline:1.0.7 image.

Output inspection

I ran the updated module locally with the existing 1.0.5 container and a local copy of the Genome Nexus fixture MAF because the configured raw GitHub test-data URL cannot address the slash branch currently used by the fixture.

The generated command includes the configured args:

java -Xms768m -Xmx3g \
    -jar /genome-nexus-annotation-pipeline/annotationPipeline/target/annotationPipeline.jar \
    --filename input.maf \
    --output-filename tiny-annotated.maf \
    --isoform-override mskcc --replace-symbol-entrez --post-interval-size 1

The output looked structurally correct:

  • tiny-annotated.maf contains #genome_nexus_version: 2.1.3 and #isoform: mskcc
  • The fixture output has 4 data rows, matching the input row count
  • The two TP53 rows were annotated successfully with TP53/7157, splice_donor_variant, Splice_Site, dbSNP, HGVSc, transcript, and RefSeq fields populated
  • The TERT and MET rows were emitted with Annotation_Status=FAILED, matching the tool log summary of 2 failed annotations

One caveat: the Genome Nexus jar logs an initial failed default batch attempt before the parameterized job completes successfully. The final parameterized job completed and Nextflow exited successfully. The current expected annotated fixture fetched from test-datasets appears stale or unannotated because it matches the input and differs from the real generated output.

Validation

  • PATH=/Users/orgeraj/miniconda3/bin:$PATH NXF_DISABLE_CHECK_LATEST=true nf-test test modules/msk/genomenexus/annotationpipeline/tests/main.nf.test --tag stub --ci
  • PATH=/Users/orgeraj/miniconda3/bin:$PATH NXF_DISABLE_CHECK_LATEST=true nf-test test --profile=docker --ci --shard 1/5 --filter process,workflow modules/msk/genomenexus/annotationpipeline/tests/main.nf.test --verbose
  • Local fixture run through Nextflow using ghcr.io/msk-access/genomenexus_annotation-pipeline:1.0.5
  • GitHub PR Update Genome Nexus annotation module args #249 nf-test matrix passed after updating the normal-test snapshot
  • Sensitive-pattern check on touched module files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant